-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript: publish alpha on npm and lots of cleanup, documentation, and more #913
Conversation
This pr accomplishes the following:
I'll mark as ready once everything is good to review |
- bug introduced in 557c82b - currently getting: `warning C5102: ignoring invalid command-line macro definition '/arch:AVX2'` - solution is to use `_options(...)` not `_definitions(...)`
This commit also rewrites the history to remove *.dll and *.so files specifically in the typescript directory that we accidentally committed. This changes commit https://github.com/jacoobes/gpt4all/commit/394fd301d1b7db4f01f0a0cd621c58f01bb791f1, which made git diverge history. https://discord.com/channels/1076964370942267462/1096848919473946694/1117439497240592484 I used the Apologies for the weird git stuff. If this PR needs to be redone, I can redo it |
Is this currently published to NPM? If not how far off is it? |
Right before publishing, I came across some bugs. Will investigate soon.
And when it’s done, it’ll be published under the alpha tag
…On Mon, Jun 12, 2023 at 9:12 PM Saul ***@***.***> wrote:
- typescript bindings officially on NPM. Will be published under the
alpha tag as it is still in active development
Is this currently published to NPM? If not how far off is it?
—
Reply to this email directly, view it on GitHub
<#913 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJS6O6CZ4NQXUGSV4X2HXDXK7EBBANCNFSM6AAAAAAY7ZDOZU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Describe your changes
Issue ticket number and link
Checklist before requesting a review
Demo
Steps to Reproduce
Notes