Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buidler-etherscan plugin import #234

Open
wants to merge 33 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@alcuadrado
Copy link
Member

commented Apr 6, 2019

This plugin was developed in this PR: nomiclabs/buidler-etherscan#2

There are a few things that are needed before merging this PR:

  1. The README describes how to install the plugin's project. Not how to install the plugin in a Buidler project. It should have been based on the rest of the plugin's READMEs.
  2. It unnecessarily extends the environment.
  3. We should figure out a way to run this on travis, or directly skip most of its tests (when in travis).
  4. I'm not sure if config is handled properly. I saw some failing tests by running WALLET_PRIVATE_KEY="0x1f922fed6c1c5d33c723e1143e1e4e9703aabb5b6a8d9a8aa685c1a08dca726b" npm run test
@MyEthereumFoundation
Copy link

left a comment

https://etherscan.io/address/0x03412181d725994b3409cd60d1f92f3a3cd636e3 swap to Ether wallet: 0xC287CF1f50D5Bd56dE70BDEc1f4103D2B733A6D4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.