-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump osc version #5
Conversation
Hi @knoblochtobias I will see what I can do to fix the build and publish these changes |
The build problem is caused by a problem in osc.js |
I think there are some more issues there, but I didn't check it out in detail. Unfortunately I don't really have the time -- when this osc PR is cleared, I'll see if it works to merge and publish regardless of the build here. would that work for you? |
Yes thats ok, thank you. |
I've commented on @knoblochtobias' osc.js pull request, but thought I'd include a note here. The issue, as far as I can tell, is that Tuio.js is using the pre-compiled In Tuio.js, I attempted to replace the Alternatively, perhaps there's some way to tell Browserify not to attempt to process certain files? I hope this helps! |
thanks for the feedback. I'd say there are two separate issues; I'll add a comment on importing the browser version in the other repo. In this case: can you give a hint which file to import? this is used in a browser, so doing
|
@knoblochtobias I have basically fixed the build locally but I need to see which file to import. If your PR goes through it will work, if not, I will need to find a workaround. |
@knoblochtobias fixed with #6 I have publish |
Hi @nomve,
can you merge this, please?
Bump osc version, otherwise you'll get in error during
npm install
while using node v8 lts.Thanks to @dmdrmc, for providing this fix.
Cheers
Tobi