Add getOrElseUpdate method to debox.Map #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change looks great. Would you be willing to add a test that uses this method? Once you do that I'd be happy to merge it. |
|
Thanks for your feedback. I just added some tests for the getOrElse and getOrElseUpdate methods. I don't usually work with scalatest, so if something's wrong please say so. |
|
Looks good to me. Thanks for adding the tests. 👍 |
non
added a commit
that referenced
this pull request
Jun 7, 2015
Add getOrElseUpdate method to debox.Map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a getOrElseUpdate method to debox.Map, which should be faster than a simple getOrElse followed by an update, as it only needs to iterate once over the possible values.