Fix: Message.__contains__() 未考虑 bool(MessageSegment) 存在 False 情况导致的异常结果
#2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RF-Tar-Railt
previously approved these changes
Feb 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2572 +/- ##
=======================================
Coverage 94.00% 94.00%
=======================================
Files 48 48
Lines 3906 3906
=======================================
Hits 3672 3672
Misses 234 234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cvandia
approved these changes
Feb 11, 2024
|
🚀 Deployed on https://deploy-preview-2572--nonebot2.netlify.app |
|
标题格式改改 |
lgc2333
changed the title
MessageSegment.__contains__MessageSegment.__contains__
lgc2333
changed the title
MessageSegment.__contains__Message.__contains__ 在目标 MessageSegment.__len__() 返回 0 时返回 False 的 Bug
lgc2333
changed the title
Message.__contains__ 在目标 MessageSegment.__len__() 返回 0 时返回 False 的 BugMessage.__contains__() 在目标 MessageSegment.__len__() 返回 0 时返回 False 的 Bug
|
补充个测试？ |
yanyongyu
changed the title
Message.__contains__() 在目标 MessageSegment.__len__() 返回 0 时返回 False 的 BugMessage.__contains__() 在 MessageSegment 为 falsy 时判断错误
|
已补充 |
yanyongyu
reviewed
Feb 11, 2024
yanyongyu
reviewed
Feb 11, 2024
RF-Tar-Railt
changed the title
Message.__contains__() 在 MessageSegment 为 falsy 时判断错误Message.__contains__() 未考虑 bool(MessageSegment) 存在 False 情况导致的异常结果
Co-authored-by: Ju4tCode <42488585+yanyongyu@users.noreply.github.com>
yanyongyu
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.