git-gutter+-stage-hunks doesn't work across Tramp

[domq]

Steps to reproduce:

• Open remote file w/ Tramp
• Select region
• M-x git-gutter+-stage-hunks

Result:

Error staging hunks:
fatal: --cached outside a repository

Platform details:
Emacs for Mac OS X (from http://emacsformacosx.com/), emacs-version 24.4.50.1

[domq]

AIUI, the trouble is that call-process-region doesn't work through tramp. The org-mode folks ran into the same problem before.

[domq]

Running the following code (cobbled together from the Git history over at https://github.com/emacsmirror/tramp) gets the hunk feature working remotely. Note that tramp-sh-handle-call-process-region was deleted in December 2012 for some reason.

(defun tramp-sh-handle-call-process-region
    (start end program &optional delete buffer display &rest args)
  "Like `call-process-region' for Tramp files."
  (let ((tmpfile (tramp-compat-make-temp-file "")))
    (write-region start end tmpfile)
    (when delete (delete-region start end))
    (unwind-protect
        (apply 'process-file program tmpfile buffer display args)
      (delete-file tmpfile))))

(defadvice call-process-region
  (around tramp-advice-call-process-region activate)
  "Invoke `tramp-sh-handle-call-process-region' for Tramp files."
  (if (eq (tramp-find-foreign-file-name-handler default-directory)
          'tramp-sh-file-name-handler)
      (setq ad-return-value
            (apply 'tramp-sh-handle-call-process-region (ad-get-args 0)))
    ad-do-it))

[domq]

Pull request #18 is a cleaned-up version of the above.

[nonsequitur]

Commited.