-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | Health fix cli arguments validation and some small fixes #8052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-nc-health-fixes
branch
2 times, most recently
from
May 19, 2024 13:23
476576b
to
7c899a8
Compare
naveenpaul1
reviewed
May 20, 2024
shirady
reviewed
May 20, 2024
romayalon
force-pushed
the
romy-nc-health-fixes
branch
from
May 20, 2024 09:04
7c899a8
to
f25c9a4
Compare
romayalon
force-pushed
the
romy-nc-health-fixes
branch
2 times, most recently
from
May 20, 2024 13:23
f098c2e
to
b812353
Compare
@romayalon could you update the doc with new changes, Other than that its LGTM |
naveenpaul1
approved these changes
May 22, 2024
romayalon
force-pushed
the
romy-nc-health-fixes
branch
4 times, most recently
from
May 29, 2024 15:39
6890b96
to
2af30b6
Compare
This PR is depenedant on validations changes, therefore it can not be backported to 5.15.4 |
romayalon
force-pushed
the
romy-nc-health-fixes
branch
3 times, most recently
from
June 10, 2024 09:30
a88934e
to
ab2bada
Compare
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
romayalon
force-pushed
the
romy-nc-health-fixes
branch
from
June 16, 2024 08:30
ab2bada
to
db26f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
ignore_rc
to - when ignore_rc=true service_status/pid/memory are undefined, when ignore_rc=false, setting them as missing so the user will know the command failed and didn't succeed.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo node --trace-warnings ./node_modules/mocha/bin/mocha /Users/romy/github/noobaa-core/src/test/unit_tests/test_nc_nsfs_health.js