-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIFECYCLE - fix issue with delete only 3K objects a day #8074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some small comments.
delete_multiple_objects_by_filter will return the number of objects deleted lifecycle will run every 5 minutes if any of its rules has deleted the max objects it can (1K - meaning he can delete more and we shouldn't wait to the next cycle) Signed-off-by: jackyalbo <jacky.albo@gmail.com>
jackyalbo
added a commit
to jackyalbo/noobaa-core
that referenced
this pull request
Jun 9, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com>
jackyalbo
added a commit
to jackyalbo/noobaa-core
that referenced
this pull request
Jun 9, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com>
jackyalbo
added a commit
to jackyalbo/noobaa-core
that referenced
this pull request
Jun 13, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit 7854feb)
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Jul 30, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit 7854feb)
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Jul 30, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit 7854feb)
dannyzaken
pushed a commit
to dannyzaken/noobaa-core
that referenced
this pull request
Sep 29, 2024
fixing part change from objects_deletes to num_objects_deleted Signed-off-by: jackyalbo <jacky.albo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: