fix(disposition): only send disposition to relevant links by role #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| var dispositionHandler = function(l) { l._dispositionReceived(disposition); }; | ||
| if (frame.role === constants.linkRole.sender) { | ||
| this._senderLinks.forEach(dispositionHandler); |
There was a problem hiding this comment.
I think this is actually reversed - the "role" is the role of the one sending you the dispo frame (so e.g. "I'm a receiver, and I'm sending this dispo frame to the sender").
There was a problem hiding this comment.
oh, indeed you are correct. The spec is very mysterious in their wording here, but it should have been obvious from the test that the sender should be the one receiving dispositions!
Previously we ignored the role of the incoming disposition frame, and forwarded these frames to the _dispositionRecieved method of all links we knew about. This patch corrects this behavior, and includes an integration test verifying that frames are forwarded to the appropriate link types.
mbroadst
force-pushed
the
disposition-roles
branch
from
1ccade0
to
f93f2a7
Compare
noodlefrenzy
added a commit
that referenced
this pull request
Jul 29, 2015
fix(disposition): only send disposition to relevant links by role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we ignored the role of the incoming disposition frame,
and forwarded these frames to the _dispositionRecieved method of
all links we knew about. This patch corrects this behavior, and
includes an integration test verifying that frames are forwarded
to the appropriate link types.