Implements the extends keyword for types defined in the dsl. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with test for extends. Working to get the tests to pass. The nools parser test for defines uses a deep equal to a known structure. There is a new property in the define parse output, extend: <typename> , this is null unless there is an actual base class. Adding null, trivial change for this. Implements the extends keyword for types defined in the dsl.
markbjerke
force-pushed
the
add-extends-to-dsl
branch
from
cde8efd
to
b8a61e5
Compare
| var _createDefined = function (action, defined, scope) { | ||
| var _createDefined = function (options, defined, scope) { | ||
| var action = options.properties | ||
| ,proto, base; |
There was a problem hiding this comment.
comma on previous line
| if (extend) { | ||
| ret.push("var proto = Object.create(flow.getDefined('" + extend + "').prototype); proto.constructor = Defined; Defined.prototype = proto;"); | ||
| } | ||
| else { |
|
I am closing this in order to resubmit after removing code that is refactoring in support of this feature and placing it into a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to inherit from types in the dsl, or from an external type introduced via the define options for a given flow.
#162