Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

631: Added new parameter to load groups as a dict instead of a list #632

Merged
merged 4 commits into from
Sep 6, 2023
Merged

631: Added new parameter to load groups as a dict instead of a list #632

merged 4 commits into from
Sep 6, 2023

Conversation

Wilhite-r
Copy link
Contributor

What changed?

  • Bug fix for Iambic detect.
    Both Iambic Apply and the setup wizard load groups for user changes as dictionary, but detect used a list. Later, we try to pull the groups as a dict, and it fails.

Rationale

  • Instead of changing the parsing of the groups, I just added a parameter to the load user function which allows the iambic detect workflow to load as a dict instead of a list.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@Wilhite-r Wilhite-r mentioned this pull request Sep 6, 2023
Closed
smoy
smoy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@smoy smoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run import locally and things are working as expected

@smoy smoy merged commit 893c707 into noqdev:main Sep 6, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoy smoy smoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wilhite-r @smoy