Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add missing swing dependency #19

Merged

Conversation

bardurdam
Copy link
Contributor

  • move scala code in examples project under examples/src/main/scala/*
    in order for sbt to include it when compiling project.
  • add scala swing dependency that was missing when upgrading to scala
    2.11 due to example project not being compiled in sbt.

- move scala code in examples project under `examples/src/main/scala/*`
  in order for sbt to include it when compiling project.

- add scala swing dependency that was missing when upgrading to scala
  2.11 due to example project not being compiled in sbt.
@norbert-radyk
Copy link
Owner

Thanks a lot, for upgrading this and apologies for the delay in the merge. I am going to merge the change, however still not 100% in my mind if keeping the code to show dialog about where to save generated report adds much value. Since does not illustrate how Spoiwo works I might remove it together with the library reference in the future. On the other side moving the examples so they are compiled every time is a good and welcome change.

@norbert-radyk norbert-radyk merged commit c6bd270 into norbert-radyk:master May 15, 2016
@bardurdam bardurdam deleted the wip-fix-swing-dependency branch May 15, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants