Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade restler to version 3.2.2 #9

Merged
merged 3 commits into from
Sep 8, 2015
Merged

Upgrade restler to version 3.2.2 #9

merged 3 commits into from
Sep 8, 2015

Conversation

kblok
Copy link
Contributor

@kblok kblok commented Nov 6, 2014

A test called "It is able to chain several calls" was added which proves that with the previous version of restler the module fails when chaining several calls due to a memory leak (see: danwrong/restler#113 and danwrong/restler#129)

This test needs a config.js file in the test folder with a trello configuration, that's why this test is ignored by default (".skip"). This file should contain something like this:

module.exports = {
    key: "some valid key",
    token: "some valid token",
    listId: "some valid listId"
};

A tests "'It is able to chain several calls'" was added which proves that with the previous version of restler the module fails when chaining several calls due to a memory leak (see: danwrong/restler#113 and danwrong/restler#129)

This tests needs a config.js file in the test folder with a trello configuration, that's why this test is ignored by default (".skip")
kblok pushed a commit to kblok/ttsync that referenced this pull request Nov 12, 2014
… until this pull request is approved (norberteder/trello#9)

Add some rules to the gitignore
@noamokman
Copy link

Why is this not being merged?

@kblok
Copy link
Contributor Author

kblok commented Jan 19, 2015

I don't know @noamokman. I've got no comments...

@noamokman
Copy link

Out of all trello packages, this is the most maintained, and yet it isn't.. what can we do?

@GraemeF
Copy link
Collaborator

GraemeF commented Jan 19, 2015

Hi guys, @devtyr is maintaining this module now and merged your last pr - maybe he is busy at the moment.

@masonforest
Copy link

@devtyr are you still maintaining this module? I'd be happy to take over if you're busy or lost interest. Thanks guys!

@sionleroux
Copy link
Contributor

I'm also eagerly awaiting this merge 👍 There's also a newer restler out in the meantime: 3.3.0 NPM Version

norberteder added a commit that referenced this pull request Sep 8, 2015
Upgrade restler to version 3.2.2
@norberteder norberteder merged commit 3f819a1 into norberteder:master Sep 8, 2015
@norberteder
Copy link
Owner

@masonforest Sorry, I migrated @devtyr to an organization and rights got lost. Everything fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants