Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Modal Props actions to required false #632

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix Modal Props actions to required false #632

merged 1 commit into from
Aug 2, 2023

Conversation

raczyk
Copy link
Contributor

@raczyk raczyk commented Aug 2, 2023

What

  • Fix Modal Props actions to required false

Testing

  • Is this change covered by the unit tests?

  • Is this change covered by the integration tests?

  • Is this change covered by the automated acceptance tests? (if applicable)

Compatibility

  • Does this change maintain backward compatibility?

Screenshots

Before

After

@raczyk raczyk requested a review from a team as a code owner August 2, 2023 09:33
@raczyk raczyk requested review from ievavizg and janosio August 2, 2023 09:33
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-632.du3gff836giqw.amplifyapp.com

@raczyk raczyk merged commit 8351a7c into master Aug 2, 2023
8 checks passed
@raczyk raczyk deleted the modal-action-require-fix branch August 2, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowyDEV nowyDEV nowyDEV approved these changes

@Horay Horay Horay approved these changes

@ievavizg ievavizg Awaiting requested review from ievavizg ievavizg is a code owner automatically assigned from nordcloud/core-frontend-reviewers

@janosio janosio Awaiting requested review from janosio janosio is a code owner automatically assigned from nordcloud/core-frontend-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raczyk @Horay @nowyDEV