Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated semantic-ui package and example #689

Merged
merged 2 commits into from
May 10, 2024

Conversation

mgcm
Copy link
Contributor

@mgcm mgcm commented May 7, 2024

Semantic UI package and examples are no longer maintained, only MUI. This PR removes the assets from the repo.

✔️ Checklist

  • [] A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Signed-off-by: Milton Moura <miltonmoura@gmail.com>
@mgcm mgcm requested a review from a team as a code owner May 7, 2024 10:24
Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: cbb1813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maheichyk
Copy link
Contributor

@mgcm could you please merge with main?

Signed-off-by: Milton Moura <miltonmoura@gmail.com>
@mgcm
Copy link
Contributor Author

mgcm commented May 9, 2024

@maheichyk updated to latest main and resolved conflicts! 🚀

Copy link
Contributor

@maheichyk maheichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mgcm mgcm changed the title Removing semantic-ui package and example, now deprecated Removing deprecated semantic-ui package and example May 10, 2024
@mgcm mgcm merged commit 8fa7d46 into main May 10, 2024
4 checks passed
@mgcm mgcm deleted the nic/feat/deprecate-semantic-ui branch May 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants