Verbosity and Logging #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Satu Koskinen <satu.a.koskinen@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
|
I found this https://github.com/clap-rs/clap-verbosity-flag which implements standard behaviour for verobosity flag. What do you guys think? |
Ah that should probably work. I personally like the variant with the log level as string more, but i can change it to use this variant if you prefer that. |
Signed-off-by: Max Winter <maxwinter00@gmail.com>
|
In my opinion |
juliuskoskela
requested changes
Dec 5, 2023
|
Alright, then i will try out the clap_verbosity_flag |
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
juliuskoskela
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the --verbosity command flag and correct logging with log levels.
I had to alter the --verbosity flag a bit. I could not get Clap's parse(from_occurrences) to work correctly.
The log level is no longer increased with -v, -vv, ..., but instead by writing the log level as a String (for example --verbosity debug).