Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with tmuxline color and vim-airline #117

Closed
ghost opened this issue Apr 14, 2018 · 4 comments · Fixed by #128
Closed

Issue with tmuxline color and vim-airline #117

ghost opened this issue Apr 14, 2018 · 4 comments · Fixed by #128
Labels
context-plugin context-ui scope-compatibility type-improvement
Milestone
version-0.10.0

Comments

@ghost
Copy link

ghost commented Apr 14, 2018

When using tmuxline.vim with nord-vim in vim-airline, I get this issue everytime I start tmux:

/<my home directory>/.tmux-status.conf:18: bad colour: NONE

After some search around the repo, I found this issue #11, which is exactly the same as mine, but was already fixed for lightline.vim.

Could this fix be also implemented for vim-airline? Thank you!
@arcticicestudio arcticicestudio self-assigned this Apr 14, 2018
@arcticicestudio arcticicestudio added this to the Next milestone Jun 24, 2018
arcticicestudio added a commit that referenced this issue Jun 24, 2018
@arcticicestudio
Improve compatibility of airline theme with tmuxline.vim theme
18add4e 
The "Nord airline.vim" (1) UI plugin theme now includes better support
for the "tmuxline.vim" (2) plugin. Previously text shown in the main
segment of the tmuxline, generated via the `:Tmuxline airline` command,
caused a `bad colour: NONE` error or has been colorized using `nord0`
which resulted in unreadable text due to a `nord3` background.

This has been fixed by using `nord5` as foreground color. See GH-11 (3)
which has been used as implementation reference that fixed the same
incompatibility for the "lightline.vim" (4) plugin.

References:

  (1) https://github.com/arcticicestudio/nord-vim/blob/develop/autoload/airline/themes/nord.vim
  (2) https://github.com/edkolev/tmuxline.vim
  (3) #11
  (4) https://github.com/itchyny/lightline.vim

GH-117
@arcticicestudio
Copy link
Contributor

@khoadcao Thanks for your contribution 👍

Sorry for the delay, I've had no free time (job 👨‍⚕️, study 📖, life 🏋️‍♂️ etc.) to work on my or any other :octocat: OSS project (see Tweets 🐦 from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again 💚

I've implemented the changes from #11 for airline by replacing the used nord4 color with nord5.
Can you please check out the improvement/gh-117-airline-tmuxline-compatibility branch and test if this fixes the error? It works fine on my system, the airline theme is automatically applied and works fine when running :Tmuxline airline too.

@arcticicestudio arcticicestudio assigned ghost and unassigned arcticicestudio Jun 24, 2018
@ghost
Copy link
Author

ghost commented Jun 25, 2018

@arcticicestudio After some testing, it seems that the patch has fixed the problem. Thank you!

Closing it now.

@ghost ghost closed this as completed Jun 25, 2018
@arcticicestudio
Copy link
Contributor

@khoadcao Thanks for your feedback 👍

I reopened this issue because it'll be closed via automation when the corresponding PR is merged 😄

@arcticicestudio arcticicestudio assigned arcticicestudio and unassigned ghost Jun 25, 2018
@arcticicestudio arcticicestudio mentioned this issue Jun 25, 2018
Merged
arcticicestudio added a commit that referenced this issue Jun 25, 2018
@arcticicestudio
Merge pull request #128 from arcticicestudio/improvement/gh-117-airli…
3150628 
…ne-tmuxline-compatibility

Improve compatibility of airline with tmuxline.vim plugin
@arcticicestudio arcticicestudio removed their assignment Dec 6, 2018
@arcticicestudio
Copy link
Contributor

🚀 Deployed in release version 🏷 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-plugin context-ui scope-compatibility type-improvement
Projects
None yet
Milestone
version-0.10.0
Development

Successfully merging a pull request may close this issue.

Improve compatibility of airline with tmuxline.vim plugin nordtheme/vim
1 participant
@arcticicestudio