Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

A better way to notify about parcels statuses #1

Closed
developerfromjokela opened this issue Jan 31, 2020 · 19 comments
Closed

A better way to notify about parcels statuses #1

developerfromjokela opened this issue Jan 31, 2020 · 19 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@developerfromjokela
Copy link
Collaborator

developerfromjokela commented Jan 31, 2020

Hello,

I was looking at the source code, and there's some requests to your server for Finland Post. Can you make that open source, so we can improve things there?

I was planning to add push notifications, because starting from Android 8.0, background threads are getting killed after a short time of running. Because of this, app's notifications aren't working. 😄

We can implement the server to push messages every x minute to check the parcels status. So the background threads will not be needed.

@norkator
Copy link
Owner

norkator commented Jan 31, 2020

That "server" is actually straight towards posti own server. I don't forward data on any way. I don't have server assosiated towards this app. So this is all source code for this whole app right here.

@norkator
Copy link
Owner

You can make new branch and add your developments there, I will review, test, merge and build done works.

@norkator
Copy link
Owner

I had long time ago problem that posti server ip was changing so I used my own domain service provider to stay up to date with their server. That problem no longer exists so I can change that to direct one.

@developerfromjokela
Copy link
Collaborator Author

developerfromjokela commented Jan 31, 2020 via email

@norkator
Copy link
Owner

Where will this php script be located at? I don't allow any random servers due privacy issues

@developerfromjokela
Copy link
Collaborator Author

developerfromjokela commented Jan 31, 2020 via email

@developerfromjokela developerfromjokela changed the title Paketin Seuranta server is not open source A better way to notify about parcels statuses Jan 31, 2020
@developerfromjokela
Copy link
Collaborator Author

@norkator Even if it's on my server, any user data will not be saved. All updates Will Be done on the user's device. Push update triggers the update. 😉

@norkator
Copy link
Owner

Okay we'll see later when I review done works. Thanks for participating.

@norkator norkator added bug Something isn't working enhancement New feature or request labels Jan 31, 2020
@developerfromjokela
Copy link
Collaborator Author

@norkator I made an separate repository for the server. https://github.com/developerfromjokela/Paketin-Seuranta-Server. You can fork it, to add more code if you want. This script will push an push message to the app, and the Firebase listener in the app is going to trigger the update.

@norkator
Copy link
Owner

norkator commented Feb 1, 2020

Now that I see that you are very skilled so I think I stay out of this fire base notification development. I can set it later to run on my server but will only use directly your version so not going to do my own forks. I let you be specialist on this thing. Have to thank you again for participating.

So basically to enabled FCM I need to set up server key, set up script on my server with it but what about at Android app side, any requirements now there?

@norkator
Copy link
Owner

norkator commented Feb 1, 2020

I double reviewed code because I don't understand this part "the Firebase listener in the app is going to trigger the update." -> I haven't yet found this " Firebase listener " so how this works or is this yet to be implemented?

@developerfromjokela
Copy link
Collaborator Author

developerfromjokela commented Feb 2, 2020 via email

@norkator
Copy link
Owner

norkator commented Feb 2, 2020

I have server key now so I set up your fcm server code up and running on my server ready for this.

@norkator
Copy link
Owner

norkator commented Feb 2, 2020

@developerfromjokela we have problem: #5

maybe should drop support for Kitkat, what do you think? or should we try keep support.

based on statistics only few people really have older Android version so obviously I will drop support.

@developerfromjokela
Copy link
Collaborator Author

developerfromjokela commented Feb 2, 2020 via email

@norkator
Copy link
Owner

norkator commented Feb 2, 2020

I just dropped it. Released update.

@developerfromjokela
Copy link
Collaborator Author

Ok. When will you release the update to Google play?

@norkator
Copy link
Owner

norkator commented Feb 2, 2020

Ok. When will you release the update to Google play?

Its already in Googles processing

@developerfromjokela
Copy link
Collaborator Author

It's done, closing the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants