Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install-space include directories #106

Merged
merged 1 commit into from Sep 23, 2020

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 18, 2020

Fixes problem described in #103 (comment) .

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@peci1
Copy link
Contributor Author

peci1 commented Sep 18, 2020

The INSTALL_INTERFACE was specifying an empty string, which is IMO wrong, because it should point to the include directory.

With this fix, I get this libnabo-targets.cmake (excerpt):

# Create imported target libnabo::nabo
add_library(libnabo::nabo STATIC IMPORTED)

set_target_properties(libnabo::nabo PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "/usr/include/eigen3;${_IMPORT_PREFIX}/include"
)

Without the fix, only the Eigen directories are there.

I'm using catkin tools to build the project, so maybe they set some directories differently than what you see...

@jlblancoc
Copy link
Contributor

Ok, you are right of course! I only tested it with local builds without "make install"

👍

@pomerlef pomerlef merged commit 16250bf into norlab-ulaval:master Sep 23, 2020
@peci1
Copy link
Contributor Author

peci1 commented Sep 23, 2020

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants