Record history when scope changes but slug does not #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to record history, we should check if there is a new slug. If the record uses the scoped module we should also check if there is a change in the scope.
parndt
reviewed
Aug 26, 2019
Co-Authored-By: Philip Arndt <git@p.arndt.io>
|
@parndt thanks for the review. I have implemented your requested change. |
|
Thanks @glampr, it makes sense and I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to record history, we should check if there is a new slug.
If the record uses the scoped module we should also check if there is a change in the scope.