Transform function options #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1094
💛 - Coveralls |
For transform functions to be reusable, it may be useful to be able
to pass additional parameters other than the inventory host object.
A typical use case is to pass in sensitive configuration data from
a separate secret management tool to the inventory data.
This change adds an additional `transform_function_options` parameter
to the `InventoryConfig`.
The transform_function_options` must be a dictionary with string keys
which are also valid python identifiers. The contents of this dict
will be passed to the transform function as `kwargs`.
Example:
```yaml
---
inventory:
transform_function: __main__.transform_inventory
transform_function_options:
password: "supersecret"
```
```python
def transform_inventory(host, password, **kwargs):
""" Example transform function which adds the password argument to
each host data
"""
host.data['password'] = password
```
Add docs and tests for transform_function_options
Fixes 290
optiz0r
force-pushed
the
transform_function_options
branch
from
9acc34f
to
54a1da3
Compare
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support, documentation and tests for a new
transform_function_optionsinventory configuration option.Fixes #290