Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort to dev dependencies #874

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Add isort to dev dependencies #874

merged 7 commits into from
Oct 3, 2023

Conversation

ktbyers
Copy link
Collaborator

@ktbyers ktbyers commented Oct 3, 2023

No description provided.

This was referenced Oct 3, 2023
Closed
Closed
@ktbyers
Copy link
Collaborator Author

ktbyers commented Oct 3, 2023 •
edited
Loading

Also upgraded black to a newer version (as now is a good time to do it).

@ktbyers
Copy link
Collaborator Author

ktbyers commented Oct 3, 2023

I added "docs" back into isort as the "nbval" issues needed fixed anyways.

@ktbyers
Copy link
Collaborator Author

ktbyers commented Oct 3, 2023 •
edited
Loading

The only file changes that should matter are:

Makefile
pyproject.toml
.github/workflows/codeql-analysis.yml      # removal

I think everything else is just minor auto-formatting changes made by isort/black or minor testing issues (nbval testing) that arose because of those changes.

Should be good to go now.

@ktbyers ktbyers merged commit 77f5c13 into nornir-automation:main Oct 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrosop dbarrosop dbarrosop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktbyers @dbarrosop