client/core: monotonic OrderBook state updates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could go even further and sanity check lower |
norwnd
commented
Mar 8, 2023
Comment on lines
-508
to
-512
| // May want to re-implement strict sequence checking. Might use these tests | ||
| // again. | ||
| // { | ||
| // label: "Unbook sell order with outdated sequence value", | ||
| // orderBook: makeOrderBook( |
There was a problem hiding this comment.
Hmm, I see relevant comment here from long time ago, but it doesn't quite answer why these were commented out in the first place ... Anyway, these tests work reasonably well with my changes - which is a good sign :)
norwnd
force-pushed
the
client-core-monotonic-book-state-updates
branch
2 times, most recently
from
30c855f
to
866a8cb
Compare
norwnd
commented
Mar 8, 2023
client/orderbook/orderbook_test.go
Outdated
Comment on lines
591
to
678
| note: makeUnbookOrderNote(5, "ob", [32]byte{'d'}), | ||
| expected: nil, | ||
| wantErr: true, | ||
| note: makeUnbookOrderNote(5, "ob", [32]byte{'b'}), | ||
| expected: makeOrderBook( | ||
| 2, | ||
| "ob", | ||
| []*Order{ | ||
| makeOrder([32]byte{'b'}, msgjson.SellOrderNum, 10, 1, 2), | ||
| makeOrder([32]byte{'c'}, msgjson.SellOrderNum, 10, 2, 5), | ||
| }, | ||
| make([]*cachedOrderNote, 0), | ||
| true, | ||
| ), | ||
| wantErr: false, |
There was a problem hiding this comment.
And this "Unbook sell order with future sequence value" test seems to have worked because it was failing due to unknown id error, not the one the name claims to test, note, I changed order ID d->b (it fails like this on master)
There was a problem hiding this comment.
Fixed other similar issues (expectation mismatch) I found in these tests too.
norwnd
force-pushed
the
client-core-monotonic-book-state-updates
branch
from
2910c73
to
4318f03
Compare
|
I've been running this PR on mainnet, and occasionally I see notes from future: ... and so it goes until disconnect 1 min later (not sure if disconect is accidental, or if it's intentional once order book goes stale): then it reconnects and continues to work without obvious issues. Full log: notes-from-future.txt So, was relaxing constraint to allow future notifications the most practical way to address it at the time ? If it ain't part of design #1 + #2 + #4 will hopefully fix it (along with ghost orders and whatnot). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent: