Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Account and Saved Accounts (Encrypted) #27

Closed
deanpress opened this issue Mar 31, 2018 · 9 comments
Closed

Create Account and Saved Accounts (Encrypted) #27

deanpress opened this issue Mar 31, 2018 · 9 comments
Assignees
Labels
enhancement New feature or request team issue This issue will be handled by the nOS core team
Milestone

Comments

@deanpress
Copy link
Member

deanpress commented Mar 31, 2018

On the authentication window, the Passphrase tab should provide the option for users to create new accounts, and to save them on creation or log-in.

Similar to neon-wallet, users should be able to select previously saved accounts (only encrypted keys) so they only have to enter their Passphrase to log in.

@mhuggins mhuggins self-assigned this Apr 7, 2018
@mhuggins
Copy link
Contributor

The creation piece of this is done. We're not storing the saved accounts to select for login though. This feels more like a nice-to-have than a must-have for the conference. Thoughts @deanpress?

@deanpress
Copy link
Member Author

Agreed. Will tag it for future!

@deanpress deanpress added the future Future functionality, man! label Apr 11, 2018
@mhuggins
Copy link
Contributor

mhuggins commented May 1, 2018

This is done!

@mhuggins mhuggins closed this as completed May 1, 2018
@mhuggins
Copy link
Contributor

mhuggins commented May 1, 2018

My mistake -- we're saving the wallet file, but we're not providing login with a prepopulated dropdown of accounts anywhere. I believe that's what the intention of this issue is, is that right @deanpress?

@mhuggins mhuggins reopened this May 1, 2018
@jeroenptrs jeroenptrs added enhancement New feature or request team issue This issue will be handled by the nOS core team and removed future Future functionality, man! labels May 1, 2018
@kitchenSpoon
Copy link
Contributor

kitchenSpoon commented May 4, 2018

@deanpress , @mhuggins we do have the functionality on the Wallet file Tab though, just that its not obvious we have the functionality

screen shot 2018-05-05 at 1 49 27 am

screen shot 2018-05-05 at 1 50 54 am

@mhuggins
Copy link
Contributor

mhuggins commented May 4, 2018

Wallet files are unencrypted though. It's not ideal to have a plaintext wallet file sitting on your computer. We may still want to support storing encrypted keys that depend on passphrase, which can then prepopulate in a select within the "passphrase" tab.

@kitchenSpoon
Copy link
Contributor

Ahh, I see thanks

@jeroenptrs jeroenptrs added this to the v0.2.0 milestone May 9, 2018
@jeroenptrs jeroenptrs modified the milestones: v0.2.0, v0.3.0 May 24, 2018
@DalderupMaurice
Copy link
Member

What's the status of this issue? @mhuggins
KitchenSpoon's PR is merged already :P

@mhuggins
Copy link
Contributor

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request team issue This issue will be handled by the nOS core team
Projects
None yet
Development

No branches or pull requests

5 participants