Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional neoscan URLs in Network Settings #86

Closed
deanpress opened this issue Apr 17, 2018 · 4 comments
Closed

Add additional neoscan URLs in Network Settings #86

deanpress opened this issue Apr 17, 2018 · 4 comments
Labels
community issue Open for community contributions enhancement New feature or request good first issue Good for newcomers

Comments

@deanpress
Copy link
Member

Currently users can only select networks from a set of predetermined neoscan URLs. We should let users add custom ones.

@deanpress deanpress added the enhancement New feature or request label Apr 17, 2018
@kitchenSpoon
Copy link
Contributor

@deanpress Do we have to validate if its a valid neoscan URL? or can the user add any string?

@robmoorman
Copy link
Contributor

Entering an invalid url is your own responsibility I would say. Keeping up your (custom) list in Redux would be the way to go. Maybe prefill (as initial state) this with the ones currently hardcoded.

@kitchenSpoon
Copy link
Contributor

Thanks @robmoorman , would asking for a name and a neoscan address, like in this page be enough?
http://cityofzion.io/neon-js/docs/en/basic_privnet.html

@DalderupMaurice DalderupMaurice added community issue Open for community contributions good first issue Good for newcomers labels Apr 26, 2018
@jeroenptrs jeroenptrs added the work in progress Open PR or an issue linked to an open PR label May 1, 2018
@kitchenSpoon
Copy link
Contributor

Is there anything else that needs to be done to move this from In progress to Done?

@mhuggins mhuggins closed this as completed May 6, 2018
@jeroenptrs jeroenptrs removed the work in progress Open PR or an issue linked to an open PR label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community issue Open for community contributions enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants