Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc and arglists metadata to defnc macro #74

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

jkxyz
Copy link
Contributor

@jkxyz jkxyz commented Oct 26, 2020

This PR adds support for an optional doc string parameter to the defnc macro, as well as updating the var metadata with an :arglists key using the props-bindings arg. This is super useful for documenting components and quickly seeing available props in e.g. CIDER's info bar.


I understand that this project is not currently being maintained. We're still happy users at Nosco and not planning to move to Helix or another library soon. We've considered forking, but for everyone else using hx, it would be great to get small improvements like this upstream.

@lilactown
Copy link
Collaborator

Much appreciated! I know that there are people who use hx out there, so I'm sure they'll appreciate this too :)

@lilactown lilactown merged commit 47d2de5 into nosco:master Oct 28, 2020
@jkxyz
Copy link
Contributor Author

jkxyz commented Oct 30, 2020

Awesome, thanks for merging! Do you plan on cutting a new release? I've upgraded our project to include hx as a git dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants