Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Nosnoc Problem Setup #1

Merged
merged 31 commits into from
Dec 8, 2022
Merged

Refactor Nosnoc Problem Setup #1

merged 31 commits into from
Dec 8, 2022

Conversation

FreyJo
Copy link
Collaborator

@FreyJo FreyJo commented Dec 7, 2022

No description provided.

@FreyJo FreyJo changed the title WIP Refactor Nosnoc Problem Setup Dec 8, 2022
apozharski
apozharski reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@apozharski apozharski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking it might pay off long term to have a stage object, if we will also later have cross-complementarity modes that sum across stages. Not necessary for now.

Aside from that, just a couple small things.

nosnoc/utils.py Outdated Show resolved Hide resolved
nosnoc/nosnoc.py Show resolved Hide resolved
nosnoc/nosnoc.py Outdated Show resolved Hide resolved
@FreyJo
Copy link
Collaborator Author

FreyJo commented Dec 8, 2022

Glad you like it! Should be all good now :)

apozharski
apozharski approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@apozharski apozharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FreyJo FreyJo merged commit 6bff1d5 into main Dec 8, 2022
@FreyJo FreyJo deleted the dev branch December 8, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apozharski apozharski apozharski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreyJo @apozharski