Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues with safari. #72

Closed
abdallahalsamman opened this issue Dec 4, 2018 · 5 comments
Closed

Rendering issues with safari. #72

abdallahalsamman opened this issue Dec 4, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@abdallahalsamman
Copy link
Member

Safari is terrible at rendering NES.css

dec-04-2018 15-35-25

@BcRikko
Copy link
Member

BcRikko commented Dec 4, 2018

What is going on? 😱
safari

@BcRikko BcRikko added the bug Something isn't working label Dec 4, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 4, 2018

This code may be the cause. 🤔
https://github.com/BcRikko/NES.css/blob/1663f704c194818460ad4b2cf7d0cb1e8c25f868/scss/base/generic.scss#L16

I commented out -webkit-font-smoothing: none;.
2018-12-04 23 08 53

but Anti-aliasing will work if I remove this code. 😭 -> #40

@jjspace
Copy link
Contributor

jjspace commented Dec 4, 2018

It seems that setting -webkit-font-smoothing: antialiased works in safari while still preventing sub-pixel antialiasing to keep those letters crisp :)

@abdallahalsamman
Copy link
Member Author

@jjspace can you create a PR of that please?

@dgrcode
Copy link

dgrcode commented Feb 2, 2021

It seems -webkit-font-smoothing: none; doesn't break the styles in Safari, at least in v13.1.1 which I just tested.

In Safari there's very little difference between none and antialiased, but I see a significant different in Chrome. With none it's sharper and cleaner (in my opinion).

Just in case you wanted to reconsider using -webkit-font-smoothing: none;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants