establish NostrEvent subclassing pattern with basic event kinds #56
Conversation
| /// | ||
| /// > Note: [NIP-01 Specification](https://github.com/nostr-protocol/nips/blob/b503f8a92b22be3037b8115fe3e644865a4fa155/01.md#basic-event-kinds) | ||
| final class RecommendServerEvent: NostrEvent { | ||
| var relayURL: URL? { |
There was a problem hiding this comment.
Would there be any validation we want to perform here to ensure it's a websocket URL (i.e., ws:// or wss://) and return nil if not?
There was a problem hiding this comment.
Not sure. We could if we want because the spec specifically says it's for relays and those will be websockets for now.
There was a problem hiding this comment.
For this specific case, I think we can be opinionated here because any other non-websocket protocol URL does not make sense on this field.
|
One more thought: this change adds support for decoding -- what are your thoughts about encoding subclass instances for signing for submission to relays? |
|
I don't think the subclasses will need to worry about signing at all. The base event type can handle that after simple, specific-kind initializers pack all the right fields of an event. I'll tackle that for these first kinds next. |
Sorry, I didn't mean that the subclasses would be responsible for signing. I just meant that the initialization of the subclass instance with the kind specific fields would/should also call the base NostrEvent class constructor initializer (so that when event signing does happen, it can just rely on the base NostrEvent fields when encoding and signing the message). Basically, what you said in the latter part. |
|
Looks awesome! I think we picked the right strategy 👍 |
…r-sdk#56) * establish NostrEvent subclassing pattern with basic event kinds Closes nostr-sdk#48 Closes nostr-sdk#49 Closes nostr-sdk#50 Closes nostr-sdk#51 * lint * validate relay URLs * add external interface for creating set metadata and recommend server events, plus tests
This PR implements a class hierarchy architecture pattern for the parent event type
NostrEventand all of its many specific kinds.The general pattern is that kinds will map to specific subclasses, which will then interpret the "raw" information contained in the parent class, primarily from the the
contentandtagsproperties.Closes #48
Closes #49
Closes #50
Closes #51