Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to BitmapDisplayer.display(...) about where image was got #149

Closed
nostra13 opened this issue Jan 23, 2013 · 6 comments
Closed

Add flag to BitmapDisplayer.display(...) about where image was got #149

nostra13 opened this issue Jan 23, 2013 · 6 comments
Labels

Comments

@nostra13
Copy link
Owner

Add flag to BitmapDisplayer.display(...) about where image was got: from memory cache, from disc cache, from network/other source.

@All_Users Comment here if you need this feature

@rfgamaral
Copy link

This means that in the case of the FadeInBitmapDisplayer it would need to read the flag and fade or not accordingly to the flag, correct? Just to make sure... I think it could be a useful flag :)

@nostra13
Copy link
Owner Author

@rfgamaral Right.

@o-antsiferov
Copy link

I think this flag is not good enough. For example: I open the app, it starts to load images from web and, say, display them in a Gallery with FadeInBitmapDisplayer (flag = Source.WEB, cacheInDisk = true, cacheInMemory=false), ok, it's good - fade in effect must occur only FIRST time image is displayed, the next time - it shouldn't work. (falg = Source.DISK). In such a case this flag will help. But the next time when I open the app flag is always Source.DISK (if I don't delete saved image file), and inside FadeInBitmapDisplayer I don't know if it's first time the image is diplayed or not?

@nostra13
Copy link
Owner Author

nostra13 commented Feb 5, 2013

@o-antsiferov I agree with you. But I don't want to add some kind of tracking of image loadings, like [imageUri <-> count of displayings], because it needs additional resources but this feature is used not so often, I think.

So I think I won't add flag to BitmapDisplayer. I'll just show how you can reach needed effect in sample project.

@nostra13
Copy link
Owner Author

nostra13 commented Feb 8, 2013

@rfgamaral @o-antsiferov You can see the way to avoid animation on every image displaying in this commit 3945afc

@rfgamaral
Copy link

Ok, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants