Realloc #3072
Closed
Realloc #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to cache task stacks (reducing them to 3 times INITSTAKSIZE if too large) to save on next task's creation (which is done for every note played in group tool). Replace kmalloc/copy/kfree sequences with new krealloc.
Replace kmalloc/copy/kfree of expanding stack with krealloc; if lucky krealloc didn't move the stack and don't need to update the stack/frame pointers.
|
Grrr, while looking at some other bits, this branch crashes in execerror with "Uknown data type (8) in getnumval!" (at ../lib/maps.k:295). Trying to figure out why... |
|
Closing pull request; there's something really weird going on I need to get to the bottom of. Even backing out last commit (that uses realloc in expandstackatleast) that worked yesterday - now fails. 'make regress_stdio" worked yesterday and now fails miserably. |
nosuchtim
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Most if/else/for statements use braces on the same line, that should be used more consistently. I've been tempted occasionally to add braces to all of the one-line if/else statements (ala Go), but there are a lot of them. Also, use olds==NULL rather than !olds.
|
Probably worthwhile running some tests automatically when compiling from
the top-level makefile.
…On Wed, Apr 19, 2023 at 7:46 AM pbarada ***@***.***> wrote:
Closing pull request; there's something *really* weird going on I need to
get to the bottom of. Even backing out last commit (that uses realloc in
expandstackatleast) that worked yesterday - now fails. 'make regress_stdio"
worked yesterday and now fails miserably.
Back to the drawing board...
—
Reply to this email directly, view it on GitHub
<#3072 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABESNSAHKHQZOBEBGDXJ7TXB73EFANCNFSM6AAAAAAXC33BC4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
besides "regress_stdio", what other tests are available to run?
On 4/19/23 11:25, Tim Thompson wrote:
Probably worthwhile running some tests automatically when compiling from
the top-level makefile.
On Wed, Apr 19, 2023 at 7:46 AM pbarada ***@***.***> wrote:
> Closing pull request; there's something *really* weird going on I
need to
> get to the bottom of. Even backing out last commit (that uses realloc in
> expandstackatleast) that worked yesterday - now fails. 'make
regress_stdio"
> worked yesterday and now fails miserably.
> Back to the drawing board...
>
> —
> Reply to this email directly, view it on GitHub
> <#3072 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AABESNSAHKHQZOBEBGDXJ7TXB73EFANCNFSM6AAAAAAXC33BC4>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#3072 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMXGS7S7F3UVGR5FRILZVLXB77YJANCNFSM6AAAAAAXC33BC4>.
You are receiving this because you modified the open/close
state.Message ID: ***@***.***>
--
Peter Barada
***@***.***
|
|
There are no other automated tests.
…On Wed, Apr 19, 2023 at 9:04 AM pbarada ***@***.***> wrote:
besides "regress_stdio", what other tests are available to run?
On 4/19/23 11:25, Tim Thompson wrote:
> Probably worthwhile running some tests automatically when compiling from
> the top-level makefile.
>
> On Wed, Apr 19, 2023 at 7:46 AM pbarada ***@***.***> wrote:
>
> > Closing pull request; there's something *really* weird going on I
> need to
> > get to the bottom of. Even backing out last commit (that uses realloc
in
> > expandstackatleast) that worked yesterday - now fails. 'make
> regress_stdio"
> > worked yesterday and now fails miserably.
> > Back to the drawing board...
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <#3072 (comment)
>,
> > or unsubscribe
> >
> <
https://github.com/notifications/unsubscribe-auth/AABESNSAHKHQZOBEBGDXJ7TXB73EFANCNFSM6AAAAAAXC33BC4
>
> > .
> > You are receiving this because your review was requested.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <#3072 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABMXGS7S7F3UVGR5FRILZVLXB77YJANCNFSM6AAAAAAXC33BC4
>.
> You are receiving this because you modified the open/close
> state.Message ID: ***@***.***>
>
--
Peter Barada
***@***.***
—
Reply to this email directly, view it on GitHub
<#3072 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABESNQEXOIUF4CIQFPW753XCAEJJANCNFSM6AAAAAAXC33BC4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace kmalloc/copy/kfree sequences with added krealloc.
Cache task stacks for reuse (saves stack allocation/free for every note played in group tool), reallocating them if too large when cached.