-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSI::Base node pathing #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notEthan
force-pushed
the
base_node_pathing
branch
4 times, most recently
from
October 12, 2019 08:47
be31b9a
to
d0664cc
Compare
notEthan
added a commit
that referenced
this pull request
Oct 12, 2019
…d here. probably a dead end but we'll see.
will return derefed JSI evaluated from root if that is a JSI; otherwise returns an instance of the class being derefed. ancestor_jsi is discarded if it is not an ancestor of the deref jsi.
unconditionally for now. conditionally later.
…onified node_document rather than the schema_node itself this will change when JSIs as schema instances work better.
…::PathedArrayNode
…ude PathedArrayNode
notEthan
force-pushed
the
base_node_pathing
branch
from
November 3, 2019 07:23
d0664cc
to
dad6c4e
Compare
notEthan
added a commit
that referenced
this pull request
Nov 27, 2019
notEthan
added a commit
to notEthan/scorpio
that referenced
this pull request
Nov 27, 2019
…he next JSI - mostly drop JSI::JSON::Node, and use new naming, pointers, etc. see also notEthan/jsi#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSI::Base is a PathedNode