Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not just json #13

Merged
merged 5 commits into from
Apr 22, 2018
Merged

Not just json #13

merged 5 commits into from
Apr 22, 2018

Conversation

notEthan
Copy link
Owner

the beginnings of some flexibility regarding content-type.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 26

  • 14 of 20 (70.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 78.503%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/scorpio/model.rb 13 19 68.42%
Totals Coverage Status
Change from base Build 11: -0.3%
Covered Lines: 734
Relevant Lines: 935
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 49

  • 26 of 37 (70.27%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 78.031%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/scorpio/model.rb 16 27 59.26%
Totals Coverage Status
Change from base Build 11: -0.7%
Covered Lines: 753
Relevant Lines: 965
💛 - Coveralls

@notEthan
add Scorpio::HTTPError#response_object. the response will contain its…
4a1f8e0 
… original body.
@notEthan
change Scorpio::HTTPError#response to #faraday_response, while I'm he…
62c5445 
…re. I will want the #response name for a Scorpio::Response in the future, I think.
@notEthan notEthan merged commit e2ed193 into master Apr 22, 2018
notEthan added a commit that referenced this pull request Apr 22, 2018
@notEthan
Merge remote-tracking branches 'origin/node', 'origin/base_url', 'ori…
99fecfd 
…gin/tags', 'origin/not_just_json', 'origin/schemaclasses' and 'origin/schema_inspect' into HEAD

#10 node
#11 base_url
#12 tags
#13 not_just_json
#14 schemaclasses
#15 schema_inspect
@notEthan notEthan deleted the not_just_json branch April 22, 2018 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notEthan @coveralls