Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.jsonが更新されていなかった #5

Merged
merged 1 commit into from
May 17, 2019

Conversation

shokai
Copy link
Member

@shokai shokai commented May 17, 2019

ref. https://scrapbox.io/Nota/kamon_の_package-lock.json_が_npm_i_すると書き換わってしまう

問題

package.json内のnameは "@notainc/kamon" だが、
package-lock.json内のnameが "kamon" のまま更新されていなかった。

その為、このリポジトリをcloneしてローカルでnpm installするとpackage-lock.jsonが更新されてしまう。

解決

npm installしなおした

動作確認

lock fileを更新しただけなので問題ないはず

@mountainboooy
Copy link
Member

LGTM 👍

@mountainboooy mountainboooy added ship it Extra attention is needed and removed please review labels May 17, 2019
@shokai shokai merged commit 038ef33 into master May 17, 2019
@shokai shokai deleted the update-lockfile branch May 17, 2019 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ship it Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants