Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added initial build request #58

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Added initial build request #58

merged 6 commits into from
Apr 1, 2020

Conversation

notaphplover
Copy link
Owner

@notaphplover notaphplover commented Mar 30, 2020 •
edited
Loading

Fixes #55 .

  • Add request.
  • Implement engine handler.
  • Add basic tests.
  • Add a test to check that it's not allowed to perform two build initial requests in the same turn.

@notaphplover notaphplover added the enhancement New feature or request label Mar 30, 2020
@notaphplover notaphplover added this to the Version 0.2.0 milestone Mar 30, 2020
@notaphplover notaphplover self-assigned this Mar 30, 2020
@notaphplover
Merge branch 'develop' into feature/build-initial-settlement-request
5527ef6
@notaphplover
Added game engine handler.
22f08c5 
Removed redundant implement clauses
@notaphplover
Added tests
2f7d8c2
@notaphplover
Added missing check.
5748f43 
It's not allowed to perform an initial request if another request is performed at the same turn
@notaphplover
Added test.
8cfb990
@notaphplover notaphplover marked this pull request as ready for review April 1, 2020 15:33
@notaphplover notaphplover requested a review from abvg9 April 1, 2020 15:33
@notaphplover notaphplover merged commit 87adf3f into develop Apr 1, 2020
@notaphplover notaphplover deleted the feature/build-initial-settlement-request branch April 1, 2020 17:58
notaphplover added a commit that referenced this pull request Apr 7, 2020
@notaphplover
Merge pull request #58 from notaphplover/feature/build-initial-settle…
2b26d27 
…ment-request

Added initial build request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abvg9 abvg9 Awaiting requested review from abvg9

Assignees

@notaphplover notaphplover

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.2.0
Development

Successfully merging this pull request may close these issues.

Implement a build initial settlement request
1 participant
@notaphplover