Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update CLI help doc for notation sign and verify in RC.1 #454

Merged
merged 17 commits into from
Dec 2, 2022
Merged

doc: update CLI help doc for notation sign and verify in RC.1 #454

merged 17 commits into from
Dec 2, 2022

Conversation

FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Nov 25, 2022 •
edited
Loading

fix #383

FeynmanZhou and others added 16 commits June 1, 2022 18:56
@FeynmanZhou
fix mistaken download URL
41121b2 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
Merge branch 'main' of https://github.com/FeynmanZhou/notation
a412364
@FeynmanZhou
update download link and refactor the documentation directory
3d0ab25 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
update documentation links in README
b1256f5 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
fix broken links in RADME.md
7ba411d 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
refine RADME.md
087f716 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
fix broken links and refine wording in README.md
58b3444 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Merge branch 'notaryproject:main' into main
23d7e8c
@FeynmanZhou
Merge branch 'main' of https://github.com/FeynmanZhou/notation
d9b14a8
@FeynmanZhou
doc: add examples in CLI help doc for notation sign and verify
29754b2 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
update help doc in notation verify command
627b27c 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
update help doc in notation sign and verify
fb6b12f 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
update CLI help doc for notation sign and verify
56d5374 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
add title and fix typo for notation sign and verify help
1c927ea 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
remove a blank line
8c3790f 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
doc: update CLI help doc for notation sign and verify in RC.1
8fae88f 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #454 (4755060) into main (53052a9) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   32.82%   33.46%   +0.64%     
==========================================
  Files          25       25              
  Lines        1237     1249      +12     
==========================================
+ Hits          406      418      +12     
  Misses        819      819              
  Partials       12       12
Impacted Files Coverage Δ
cmd/notation/sign.go 39.17% <100.00%> (+1.94%) ⬆️
cmd/notation/verify.go 33.76% <100.00%> (+8.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FeynmanZhou FeynmanZhou added this to the RC-1 milestone Nov 25, 2022
yizha1
yizha1 reviewed Nov 25, 2022
View reviewed changes
cmd/notation/sign.go Outdated Show resolved Hide resolved
@FeynmanZhou
update cli help doc for notation sign and verify
4755060 
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou added documentation Improvements or additions to documentation UX User experience changes labels Nov 25, 2022
yizha1
yizha1 approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrickzheng200
patrickzheng200 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit a6e6fa0 into notaryproject:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yizha1 yizha1 yizha1 approved these changes

@patrickzheng200 patrickzheng200 patrickzheng200 approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation UX User experience changes
Projects
None yet
Milestone
RC-1
Development

Successfully merging this pull request may close these issues.

Add examples for notation command help doc
5 participants
@FeynmanZhou @codecov-commenter @priteshbandi @patrickzheng200 @yizha1