Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sha1 to sha256 and other chores #665

Merged
merged 1 commit into from
May 16, 2023

Conversation

priteshbandi
Copy link
Contributor

Fixes: #611 and #635

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #665 (fdb0d31) into main (5516199) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   33.33%   33.30%   -0.04%     
==========================================
  Files          32       32              
  Lines        2019     2021       +2     
==========================================
  Hits          673      673              
- Misses       1324     1326       +2     
  Partials       22       22              
Impacted Files Coverage Δ
cmd/notation/inspect.go 14.21% <0.00%> (-0.15%) ⬇️
cmd/notation/internal/truststore/truststore.go 10.60% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Two-Hearts
Copy link
Contributor

By searching Sha1 in Notation CLI, I found we are also showing Sha1 in the notation cert show command:


Should we also change it to Sha2 in this PR?

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgnote
Copy link
Contributor

rgnote commented May 16, 2023

LGTM

@priteshbandi priteshbandi merged commit b10950d into notaryproject:main May 16, 2023
@priteshbandi priteshbandi deleted the sha1 branch May 16, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notation inspect incorrectly prints expiry in signed attribtues
6 participants