Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CODEOWNERS and MAINTAINERS files #85

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Feb 8, 2023

Signed-off-by: Toddy Mladenov toddysm@gmail.com

This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/roadmap sub-project:
Add Feynman Zhou #82
Add Pritesh Bandi #79
Add Samir Kakkar #80
Add Toddy Mladenov #83
Add Vani Rao #81
Add Yi Zha #84

The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm
Copy link
Contributor Author

toddysm commented Feb 8, 2023

Linking the issue #78

yizha1
yizha1 previously approved these changes Feb 9, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

SteveLasker
SteveLasker previously approved these changes Feb 14, 2023
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are GH errors for lines 3 and 10, but those could be resolved separately.

vaninrao10
vaninrao10 previously approved these changes Feb 14, 2023
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

gokarnm
gokarnm previously approved these changes Feb 14, 2023
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
priteshbandi
priteshbandi previously approved these changes Feb 14, 2023
Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Also, we need to fix permission issue, which can be done later

iamsamirzon
iamsamirzon previously approved these changes Feb 14, 2023
justincormack
justincormack previously approved these changes Feb 16, 2023
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.