-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #162
Update dependencies #162
Conversation
NB spurious test failures with weird |
Wow, good work! Thank you very much I think this is alright, but I'll make CI run a few more times to get the spurious failures some extra coverage before merging (after the inotify fix is in). |
Hmm, the windows test fails consistently (not just in this PR) on Also could you move |
Windows tests failed for me consistently before I started - all of I'll move the code around as you propose and push shortly. I'd suggest not merging this - or certainly not publishing it - until a fix for that |
Certainly. I've subscribed to the inotify issue, too :) |
@@ -34,7 +34,7 @@ fsevent = "^0.2.17" | |||
fsevent-sys = "^0.1.3" | |||
|
|||
[target.'cfg(windows)'.dependencies] | |||
winapi = "^0.2.5" | |||
winapi = "^0.3.5" | |||
kernel32-sys = "^0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When upgrading winapi to "0.3", kernel32-sys
should be dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, thanks
I've merged hannobraun/inotify-rs#117 and released inotify 0.6.1. |
@hannobraun thanks! I've updated this pull request to match |
Thanks all! I'll merge and release tomorrow (for me). In ~12 hours |
Released in 4.0.5 |
I've updated a bunch of dependencies, in a series of commits.
Much the biggest was
mio
.I don't have access to a mac, so
fsevent
is left as an exercise for the reader.