New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No check that localAvailable is negative in liquidateLocalCurrency #11

Closed

T-Woodward opened this issue Apr 19, 2021 · 1 comment

Contributor

T-Woodward commented Apr 19, 2021

The calculation of benefitRequired assumes that localAvailable is negative, but we don't currently require that to be the case in the function:

contracts-v2/contracts/internal/liquidation/LiquidateCurrency.sol

Line 41 in a2d3099

function liquidateLocalCurrency(

jeffywu added a commit that referenced this issue


          Fixes #11

3eac538

Contributor

jeffywu commented Apr 22, 2021

@T-Woodward confirm fix in 3eac538

T-Woodward closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment