Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/series #125

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

feature/series #125

wants to merge 23 commits into from

Conversation

marcjulian
Copy link
Member

  • feat(series): add series page
  • feat(series): map chapter items and sort by weight
  • feat(tailwind): optin to future changes

@github-actions
Copy link

github-actions bot commented Dec 1, 2020 •
edited
Loading

Visit the preview URL for this PR (updated for commit c45da56):

https://notiz-dev--pr125-feature-series-1ezoqkdc.web.app

(expires Mon, 08 Feb 2021 16:18:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@marcjulian marcjulian linked an issue Dec 18, 2020 that may be closed by this pull request
article series #6
Open
@marcjulian
Copy link
Member Author

marcjulian commented Dec 18, 2020 •
edited
Loading

  • Chapters disappear and appear randomly on navigation
  • Generate banner for Series
  • Include in search

garygrossgarten
garygrossgarten approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@garygrossgarten garygrossgarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor out chip class, otherwise LGTM

@marcjulian
Copy link
Member Author

marcjulian commented Jan 7, 2021 •
edited
Loading

@garygrossgarten scully builds is only failing on CI. I don't have any errors localy. Strangly it is failing with and without the lazyImage plugin.

Never mind, I deleted dist/static folder and it also fails locally. also removing the lazyImage plugin does not have any effect on /series route. It might work if the banner plugin would be a routeDiscoveryDone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garygrossgarten garygrossgarten garygrossgarten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

article series
2 participants
@marcjulian @garygrossgarten