Refactor helpers as tag classes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gael-ian
added a commit
that referenced
this pull request
Mar 7, 2023
* Introduce Tag classes and use them to build move link * Tags generates their own default label * Decline Tags::Base for each action * Add missing tests on Tags classes * Simplify helpers tests now Tag classes are fully tested * Cleanup after helpers specs refactoring * Simplify Cocooned::Association::Builder interface * Add missing tests on Cocooned::Association::Renderer * Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge refactor of Cooconed view helpers and associated classes.
So far, the structure of the original Cocoon had been kept, with minimal OO programming and huge functional helpers with multiple associated private methods added to ActionView::Base.
This extract helpers logic to dedicated classes and remove almost all methods from ActionView::Base except for the documented helpers.