[WIP] Cross-compile core, testkit and boopickle macro to scala.js #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavkin
commented
Nov 8, 2018
| lazy val coreJS = core.js | ||
| lazy val coreJVM = core.jvm | ||
|
|
||
| lazy val boopickleWireProtocol = crossProject(JSPlatform, JVMPlatform) |
There was a problem hiding this comment.
sadly this crossProject thingy has to be directly assigned to a val. can't extract it into a method
vpavkin
changed the title
|
@vpavkin - thank you very much! :-) Fyi @karolchmist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of scala.js build. (originated in #54 )
@SemanticBeeng Here you go.
Just have to setup runtime for js tests and maybe separate platform independent tests into a cross-project.
You can pick up from here if you want.