Newline in VERSION file causes HTTP request failure #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A newline was introduced into the VERSION file in 1.1.0; because it is also used in the user-agent string for HTTP requests, it could cause 400 responses from strict servers that reject the malformed headers.
|
Sorry about that. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A newline introduced at the end of the VERSION file is causing discovery to fail on our OpenID provider due to malformed headers. SWD adds a user-agent header of "SWD (#{VERSION})" to its requests, so when VERSION contains a newline, we end up getting a "400 Bad Request" response from our server.
The fix here is to strip whitespace from what we read from VERSION.