Ads api #100
Ads api #100
Conversation
Adds the AdAccount model for use with the Ads API. There are still a few fields that are not implemented, like users and account_groups, but it's a good start.
Adds the AdCampaign model to represent an advertising campaign.
Made more concise and removed some testing code.
|
Great job, thanks! BTW, may I change the file name from adaccount.rb to ad_account.rb? (adcampaign.rb too) |
|
Yeah, I'm fine with the underscore naming scheme. I was trying to match the naming scheme facebook has here: http://developers.facebook.com/docs/reference/ads-api/ but I'm fine with your way. Also, I did some metaprogrammy tricks to make the initialization of the objects a little more concise. If you don't like that we can make things a little more explicit. Personally, I like the conciseness and I think it's pretty easy to understand, but I understand that some people prefer to keep it simple. |
|
Thanks. |
Hi,
We're working with the Facebook Ads API and fb_graph seemed like a good fit. We'll be adding several Ads API related models and were hoping to contribute back to the main project, if possible. This first pull request is for the basics of the AdAccount model, along with specs.
I'm still a bit new at Github pull requests and topic branches. I'm sure you probably don't want my .gitignore changes, but I couldn't figure out how to screen that commit out of the pull request. I also tried to make a topic branch with the feature, but I may have done that incorrectly as well.
Please let me know what else I can do.
Thanks,
Micah Wedemeyer
BLiNQ Media