Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implicit conversion of symbol to number #86

Closed
deadkarma opened this issue Jul 22, 2015 · 0 comments
Closed

No implicit conversion of symbol to number #86

deadkarma opened this issue Jul 22, 2015 · 0 comments

Comments

@deadkarma
Copy link
Contributor

In FbGraph2::Comment the from attribute is defined as a 'user' https://github.com/nov/fb_graph2/blob/master/lib/fb_graph2/comment.rb#L9

But a commenter can also be a 'Page'.
While a Page and User both can act very similarly, there's at least one attribute that is different:
The hometown attribute on a User is a Page, but for a Page, the hometown is a string, causing this error to happen on this line:

https://github.com/nov/fb_graph2/blob/master/lib/fb_graph2/attribute_assigner.rb#L71

@nov Would moving the from attribute to be custom make sense here?
I'm not sure how else to fix this.

@nov nov closed this as completed in fb532b0 Jul 22, 2015
joovam pushed a commit to joovam/fb_graph2 that referenced this issue Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant