Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider changing hash information sent after success ? #4

Closed
pjammer opened this issue May 4, 2011 · 5 comments
Closed

Provider changing hash information sent after success ? #4

pjammer opened this issue May 4, 2011 · 5 comments

Comments

@pjammer
Copy link

pjammer commented May 4, 2011

In my hash that gets sent back to the client app, after first authorization is successful, is there a way to include the user's email and other information in that hash?

Any help would be great.

When i get the hash back, shouldn't there be a UID or something? If not what method do i change to add one?

provider: myname
uid:
credentials:
token: longasstokenhere9283sids2932==

@nov
Copy link
Owner

nov commented May 6, 2011

If you want to do so temporally, overwrite Rack::OAuth2::AccessToken::Bearer (I assume you use bearer token).
If it's long-term plan, I recommend you not to implement it now and wait until OpenID Connect comes out.

@pjammer
Copy link
Author

pjammer commented May 6, 2011

Hi nov,

I wrote this before i understood how omniauth effects what you see when you get the final call back. The aha oprah moment for me was that i have go into the access_token stage and then hit a separate url that houses the information i need, which sends a hash of info back to the consumer app. It makes sense now, but at the time it seemed odd.

OpenID Connect, eh? i'll google, but if it's like the last implementation with long arsed urls, I'll stick to Oauth.

I just want to say thanks for this gem too and for your sample apps. I chose the Mac support one, but you must still be hacking on it eh? I've changed some things to make it work with my app. Also in the Mac support gem, you reference Rack::OAuth2::AccessToken::Bearer a lot in the app's source code, but shouldn't that be Rack::OAuth2::AccessToken::MAC instead?

@nov
Copy link
Owner

nov commented May 6, 2011

For mac token, see this sample.
http://github.com/nov/rack-oauth2-sample-mac

nov

On May 6, 2011, at 6:13 PM, pjammerreply@reply.github.com wrote:

Hi nov,

I wrote this before i understood how omniauth effects what you see when you get the final call back.

OpenID Connect, eh? i'll google, but if it's like the last implementation with long arsed urls, I'll stick to Oauth.

I just want to say thanks for this gem too and for your sample apps. I chose the Mac support one, but you must still be hacking on it eh? I've changed some things to make it work with my app. Also in the Mac support gem, you reference Rack::OAuth2::AccessToken::Bearer a lot in the app's source code, but shouldn't that be Rack::OAuth2::AccessToken::MAC instead?

Reply to this email directly or view it on GitHub:
#4 (comment)

@pjammer
Copy link
Author

pjammer commented May 6, 2011

Yeah I'm commenting on it too now. I'll close this issue. Would love to talk more over there. thanks.

@pjammer pjammer closed this as completed May 6, 2011
@pjammer
Copy link
Author

pjammer commented May 6, 2011

Ugh, i WANTED to git clone the mac app, looks like i git cloned the bearer app... my bad, but the fixes I'm adding work in both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants