Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted invokeObject method in router for PHP7 #175

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

volter9
Copy link
Contributor

@volter9 volter9 commented Aug 25, 2015

Thanks to @jimgwhit for testing the code on PHP7 😃

@jimgwhit
Copy link
Contributor

@volter9 where is your framework branch?

@jimgwhit
Copy link
Contributor

Dave, once this is pushed, framework works on php 7 back to php 5.4 as is. But by all means test out error handling. The new throwable interface really made things easier.

@volter9
Copy link
Contributor Author

volter9 commented Aug 25, 2015

@volter9 where is your framework branch?

I didn't really get what you mean. I requested pull requested from mine form master to SMVCF repo's master. If that's what you mean.

@jimgwhit
Copy link
Contributor

You don't have an online branch?

@volter9
Copy link
Contributor Author

volter9 commented Aug 25, 2015

What is an online branch?

@jimgwhit
Copy link
Contributor

I meant fork

@volter9
Copy link
Contributor Author

volter9 commented Aug 25, 2015

That's my fork:
https://github.com/volter9/framework-1

@dcblogdev
Copy link

Massive thanks to you both @volter9 @jimgwhit I haven't been able to spend much time on smvc recently too many deadlines as work.

@dcblogdev dcblogdev closed this Aug 26, 2015
@dcblogdev dcblogdev reopened this Sep 9, 2015
dcblogdev pushed a commit that referenced this pull request Sep 9, 2015
Adjusted invokeObject method in router for PHP7
@dcblogdev dcblogdev merged commit 4424044 into nova-framework:master Sep 9, 2015
@jimgwhit jimgwhit mentioned this pull request Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants