Add nullable: true
on optional fields
#3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to biocad#71
I made all
Maybe
fields both optional (not in the required list) and nullable because this is what Aeson does.This is easily done when the definition is inlined, you just add
nullable: true
to the definition.When we have Ref, OpenApi 3.0 sucks. See:
OAI/OpenAPI-Specification#1368
In the end I followed the recommendation made here: OpenAPITools/openapi-generator#14181 (comment)
The first commit should be mergeable to upstream should anyone want to.
The second commit is specific to this fork since it simplifies #2 (by relying on the first commit changes). It also fixes some doctests failures introduced by #2.
The third commit should be mergeable to upstream as well. It fixes the validation in presence of nullable true.