Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateOnly TimeOnly ZERODATE #24

Closed
wants to merge 14 commits into from

Conversation

tomohisa
Copy link

@tomohisa tomohisa commented May 24, 2016

MySQL has

  • Date YYYY-MM-DD
  • Time HH:MM:DD
    Fields, original could not handle those data properly.

Also, MySQL allows to put ZeroPadded data like
0000-00-00 00:00:00
depends on session setting.

this PR let this library to use above features.

novi and others added 11 commits March 19, 2016 00:13
# Conflicts:
#	Makefile
#	Package.swift
#	Sources/MySQL/Connection.swift
#	Sources/MySQL/Date.swift
#	Sources/MySQL/Query.swift
MySQL has
- Date YYYY-MM-DD
- Time HH:MM:DD
Fields, original could not handle those data properly.

Also, MySQL allows to put ZeroPadded data like
0000-00-00 00:00:00
depends on session setting.

this PR let this library to use above features.
@tomohisa tomohisa changed the title For pull req dateonly Support DateOnly TimeOnly ZERODATE May 24, 2016
@novi
Copy link
Owner

novi commented May 26, 2016

Thank you @tomohisa!

I have found out some MySQL libraries,

http://dev.mysql.com/doc/connector-j/5.1/en/connector-j-installing-upgrading-3-0-to-3-1.html
http://komono.jp/contents/memo/java/jdbcmysql/
http://d.hatena.ne.jp/hilapon/20130603/1370243377

I assume that follow just zeroDateTimeBehavior of JDBC is good consideration to work with MySQL 0000-00-00 date in Swift.

Also supporting date or time only format is good. I have new issue #25 for this.

@novi
Copy link
Owner

novi commented Jun 2, 2016

Close this issue due to go ahead with #25.

@novi novi closed this Jun 2, 2016
@tomohisa tomohisa deleted the for-pull-req-dateonly branch October 18, 2016 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants